Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace @ycombinator with @lahsivjar as codeowner for elasticsearchexporter #35322

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Replace @ycombinator with @lahsivjar as codeowner for elasticsearchexporter #35322

merged 3 commits into from
Sep 21, 2024

Conversation

ycombinator
Copy link
Contributor

Description:

This PR replaces @ycombinator with @lahsivjar as one of the codeowners for the elasticsearchexporter component.

Over the past few months, @lahsivjar has been a far more active contributor to this component than @ycombinator.

@ycombinator ycombinator requested a review from a team as a code owner September 20, 2024 14:00
@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 20, 2024
@andrzej-stencel
Copy link
Member

@ycombinator This change needs to be done https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/elasticsearchexporter/metadata.yaml. The CODEOWNERS file is generated from the metadata files.

@carsonip
Copy link
Contributor

+1 on the proposal. Thank @ycombinator and @lahsivjar

@ycombinator
Copy link
Contributor Author

@ycombinator This change needs to be done https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/elasticsearchexporter/metadata.yaml. The CODEOWNERS file is generated from the metadata files.

Thanks @andrzej-stencel for pointing that out. Done in c008817.

codeboten
codeboten reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ycombinator, just waiting for a ✅ from @lahsivjar

@crobert-1
Copy link
Member

From failing CI check:

Generated code is out of date, please run "make generate" and commit the changes in this PR.

This will update the exporter's README to include the updated code owners 👍

lahsivjar
lahsivjar approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ycombinator!

@ycombinator
Copy link
Contributor Author

Thanks @ycombinator!

No, thank you for taking this on!

@ycombinator
Copy link
Contributor Author

ycombinator commented Sep 20, 2024 •
edited
Loading

From failing CI check:

Generated code is out of date, please run "make generate" and commit the changes in this PR.

This will update the exporter's README to include the updated code owners 👍

Thanks @crobert-1. Done in c651f6b.

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 20, 2024
@dmitryax dmitryax merged commit 891f0ea into open-telemetry:main Sep 21, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 21, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
@ycombinator @jriguera
Replace @ycombinator with @lahsivjar as codeowner for elasticsearchex…
7a1681b 
…porter (open-telemetry#35322)

**Description:** 

This PR replaces @ycombinator with @lahsivjar as one of the codeowners
for the `elasticsearchexporter` component.

Over the past few months, @lahsivjar has been a far more active
contributor to this component than @ycombinator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@crobert-1 crobert-1 crobert-1 approved these changes

@carsonip carsonip carsonip approved these changes

@lahsivjar lahsivjar lahsivjar approved these changes

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar bryan-aguilar is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

Assignees

@dmitryax dmitryax

Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.110.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ycombinator @andrzej-stencel @carsonip @crobert-1 @codeboten @lahsivjar @dmitryax