Add new ParseBytes OTTL function #35296
Closed
+185
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir integer byte sizes
jdeff
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@jdeff I missed this one in my notifications. Can you open an issue for us to discuss the problem this PR solves? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new OTTL function for parsing a humanized string representation of a byte size into an integer number of bytes. This allows us to use the
transformprocessorto convert log lines from Heroku which contain metrics in the form of "sample#memory-total=123MB" into something useable when graphing.The actual logic for parsing is provided by the
go-humanizepackage which is already a dependency of opentelemetry-collector-contrib.Testing:
ParseBytesfunction in a similar way as the other OTTL functionssyslogreceiverandtransformprocessorwhen processing logs from Heroku.Documentation:
Added a similar blurb for
ParseBytesin pkg/ottl/ottlfuncs/README.md