[exporter/elasticsearch] Revert TSDB array dimension workaround for metrics OTel mode #35291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
reviewed
Sep 23, 2024
.chloggen/elasticsearchexporter_revert-array-dimension-workaround.yaml
Outdated
Show resolved
Hide resolved
…und.yaml Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
lahsivjar
approved these changes
Sep 23, 2024
felixbarny
reviewed
Sep 23, 2024
.chloggen/elasticsearchexporter_revert-array-dimension-workaround.yaml
Outdated
Show resolved
Hide resolved
felixbarny
approved these changes
Sep 23, 2024
andrzej-stencel
approved these changes
Sep 25, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etrics OTel mode (open-telemetry#35291) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Remove the workaround in open-telemetry#35009 to stringify array dimensions as the limitation has been lifted in Elasticsearch in elastic/elasticsearch#110387 This change is not breaking as array will be coerced as string, meaning that there will be no indexing error. Additionally, the changes are acceptable as OTel mapping mode explicitly marked as in development. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Vishal Raj <vishal.raj@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the workaround in #35009 to stringify array dimensions as the limitation has been lifted in Elasticsearch in elastic/elasticsearch#110387
This change is not breaking as array will be coerced as string, meaning that there will be no indexing error. Additionally, the changes are acceptable as OTel mapping mode explicitly marked as in development.
Link to tracking Issue:
Testing:
Documentation: