[connector/servicegraph]Servergraph component does not merge different dimension metrics #35287 #35288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
reviewed
Sep 23, 2024
|
Unit tests have been added. |
hongweipeng
force-pushed
the
fix-servergraph-merge-diff-dimensions
branch
from
03d7499
to
765f0dd
Compare
mapno
approved these changes
Oct 3, 2024
crobert-1
reviewed
Oct 3, 2024
| continue | ||
| for _, kind := range []string{serverKind, clientKind} { | ||
| for _, dimName := range p.config.Dimensions { | ||
| if dim, ok := edgeDimensions[kind+"_"+dimName]; ok { |
There was a problem hiding this comment.
Suggested change
| if dim, ok := edgeDimensions[kind+"_"+dimName]; ok { | |
| if dim, ok := edgeDimensions[kind + "_" + dimName]; ok { |
Nit: Whitespace around + operator.
There was a problem hiding this comment.
There is no space in the original code, such as in the upsertDimensions function. I think it is better to keep the original style.
Co-authored-by: Curtis Robert <crobert@splunk.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Servergraph component does not merge different dimension metrics。
Link to tracking Issue:
#35287