Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/sqlquery] fail on missing value for logs, collect errors #35189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[receiver/sqlquery] fail on missing value for logs, collect errors #35189

wants to merge 2 commits into from

Conversation

Grandys
Copy link
Contributor

@Grandys Grandys commented Sep 14, 2024

Description:

  • [breaking] Fail if for log column not found in result set (for consistency with metrics behaviour)
  • Instead of fail-fast, collect all errors that occurred when transforming row to metric or log

Link to tracking Issue: #35068

Testing: Added/updated unit tests

Documentation: n/a

Closes #35068

@Grandys Grandys requested a review from a team September 14, 2024 10:51
@Grandys Grandys mentioned this pull request Sep 14, 2024
Open
crobert-1
crobert-1 approved these changes Sep 16, 2024
View reviewed changes
receiver/sqlqueryreceiver/logs_receiver.go Outdated Show resolved Hide resolved
@Grandys Grandys mentioned this pull request Sep 17, 2024
Open
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 18, 2024
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@dmitryax dmitryax

Labels
internal/sqlquery ready to merge Code review completed; ready to merge by maintainers receiver/sqlquery SQL query receiver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/sqlquery] Improve error handling for missing columns in result set
3 participants
@Grandys @crobert-1 @dmitryax