[chore]: enable float-compare rule from testifylint #35167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/float-compare
branch
from
ff882f1
to
26bcf60
Compare
github-actions
bot
added
internal/aws
receiver/awscontainerinsight
receiver/hostmetrics
receiver/prometheus
github-actions
bot
requested review from
Aneurysm9,
braydonk,
dashpole,
dmitryax,
hughesjj,
mxiamxia and
pxaws
mmorel-35
force-pushed
the
testifylint/float-compare
branch
from
26bcf60
to
68939f0
Compare
github-actions
bot
added
exporter/alertmanager
processor/cumulativetodelta
github-actions
bot
requested review from
jpkrohling,
mcube8,
sokoide and
TylerHelmuth
mmorel-35
force-pushed
the
testifylint/float-compare
branch
from
68939f0
to
db2ca6e
Compare
github-actions
bot
added
connector/routing
exporter/awsemf
mmorel-35
requested review from
bogdandrutu,
evan-bradley,
mx-psi,
songy23,
bryan-aguilar and
mwear
as code owners
songy23
approved these changes
Sep 13, 2024
djaglowski
requested changes
Sep 13, 2024
There was a problem hiding this comment.
It seems unlikely that 0.01 is an appropriate level of precision for every float comparison across all tests in the codebase.
For example, in one instance we were validating the number 3.15759539000001e+08 exactly (which presumably reflects an intended value of 3.15759539e+08), but now we would be passing it if it were 3.166 or 3.148
I think we need to try to ascertain an intended level of precision on a case by case basis, and short of that we should not adopt the linter if the current code is not causing problems.
|
I can drop this PR and the other on opentelemetry-collector and focus on other rules if you want? |
|
I'm open to other opinions but mine is that this linter doesn't provide much value unless we're encountering problems from not using it. |
mmorel-35
force-pushed
the
testifylint/float-compare
branch
5 times, most recently
from
f5c9b70
to
e1785be
Compare
mmorel-35
force-pushed
the
testifylint/float-compare
branch
2 times, most recently
from
3cf7232
to
52b8f49
Compare
mmorel-35
force-pushed
the
testifylint/float-compare
branch
3 times, most recently
from
fdceb2b
to
a51e559
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/float-compare
branch
from
a51e559
to
64e4088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables float-compare rule from testifylint