[receiver/kubeletstats] Add feature gate for cpu utilization metrics' deprecation #35139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
4 times, most recently
from
55270f1
to
34525a5
Compare
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
2 times, most recently
from
858405b
to
732836c
Compare
povilasv
reviewed
Sep 17, 2024
Comment on lines
296
to
299
| Users can use the following metrics instead: | ||
| - `k8s.node.cpu.usage` | ||
| - `k8s.pod.cpu.usage` | ||
| - `container.cpu.usage` |
There was a problem hiding this comment.
I would maybe add a note that usage metrics are not utilization metrics. So it's not one to one replacement.
Something like:
Note: usage metrics show usage in terms of resources such as CPU / bytes, not percentage used.
Previous utilization metric values were computed incorrectly.
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
from
732836c
to
a699e0b
Compare
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
from
a699e0b
to
211faf9
Compare
TylerHelmuth
approved these changes
Sep 20, 2024
… deprecation Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
from
25d26e0
to
7aef1b5
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
kubeletstats_featuregate_metrics
branch
from
7aef1b5
to
a07194c
Compare
|
/cc @dmitryax |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
… deprecation (open-telemetry#35139) **Description:** This PR adds a feature gate as discussed at open-telemetry#27885 (comment). If the feature gate is enabled the `container.cpu.utilization`, `k8s.pod.cpu.utilization` and `k8s.node.cpu.utilization` metrics will be not be disabled being replaced by the `container.cpu.usage`, `k8s.pod.cpu.usage` and `k8s.node.cpu.usage`. ### Feature gate schedule - alpha: when enabled it makes the .cpu.usage metrics enabled by default - beta: .cpu.usage metrics are enabled by default and any configuration enabling the deprecated .cpu.utilization metrics will be failing. Explicitly disabling the feature gate provides the old (deprecated) behavior. - stable: .cpu.usage metrics are enabled by default and the deprecated metrics are completely removed. - Removed three releases after `stable`. **Documentation:** ### How to test this 1. Using the following configuration ```yaml mode: daemonset presets: kubeletMetrics: enabled: true image: repository: otelcontribcol-dev tag: "latest" pullPolicy: IfNotPresent command: name: otelcontribcol extraArgs: [--feature-gates=receiver.kubeletstats.enableCPUUsageMetrics] config: exporters: debug: verbosity: normal receivers: kubeletstats: collection_interval: 10s auth_type: 'serviceAccount' endpoint: '${env:K8S_NODE_NAME}:10250' insecure_skip_verify: true service: pipelines: metrics: receivers: [kubeletstats] processors: [batch] exporters: [debug] ``` 2. Ensure that only the `.cpu.usage` metrics are reported. 3. Disable the feature gate and check that only the `.cpu.utilization` metrics are reported. --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a feature gate as discussed at #27885 (comment).
If the feature gate is enabled the
container.cpu.utilization,k8s.pod.cpu.utilizationandk8s.node.cpu.utilizationmetrics will be not be disabled being replaced by thecontainer.cpu.usage,k8s.pod.cpu.usageandk8s.node.cpu.usage.Feature gate schedule
stable.@TylerHelmuth @dmitryax let me know what you think about this approach.
Link to tracking Issue:
Testing:
Documentation:
How to test this
.cpu.usagemetrics are reported..cpu.utilizationmetrics are reported.