-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][pkg/ottl] Use faster json parsing library #35130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I don't think it's entirely necessary, but adding a changelog might be nice. Sharing that this is a performance enhancement is a plus, and it'd be slightly more easy to find this as a change to pkg/ottl
if this ends up causing any unexpected bugs. Just a thought.
Any benchmarks? |
I just added one using the same test file as #33785 but am seeing no meaningful change. Not sure how to explain it. I pushed it up in case someone else sees anything I'm missing. |
@BinaryFissionGames pointed out to me offline that the benchmark was just getting the function but not executing it. Now I see a nice improvement:
|
aa55529
to
d8254a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djaglowski please handle the merge conflicts
d8254a2
to
7b5a3eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This follows open-telemetry#33785 by switching to a faster json library.
This follows #33785 by switching to a faster json library.