Add admission_blocked span to otel-arrow admission controller #35031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
commented
Sep 5, 2024
| return &BoundedQueue{ | ||
| maxLimitBytes: maxLimitBytes, | ||
| maxLimitWaiters: maxLimitWaiters, | ||
| waiters: orderedmap.New[uuid.UUID, waiter](), | ||
| tracer: tp.Tracer("otel-arrow/admission"), |
There was a problem hiding this comment.
@codeboten I tried to figure out how to have mdatagen spit out a generated_status.go file containing the ScopeName. I dug into the mdatagen sources and find that packages don't have scope name generated. What should I do?
There was a problem hiding this comment.
I've set the scope name to github.com/open-telemetry/opentelemetry-collector-contrib/internal/otelarrow
moh-osman3
approved these changes
Sep 5, 2024
…tor-contrib into jmacd/admitspan
mwear
approved these changes
Sep 6, 2024
songy23
added
the
ready to merge
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…elemetry#35031) **Description:** Adds a span to make admission controller-induced latency visible via traces. **Link to tracking Issue:** open-telemetry/otel-arrow#244 previous effort, I forgot I had moved this package to contrib. 😁 **Testing:** ✅
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…elemetry#35031) **Description:** Adds a span to make admission controller-induced latency visible via traces. **Link to tracking Issue:** open-telemetry/otel-arrow#244 previous effort, I forgot I had moved this package to contrib. 😁 **Testing:** ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds a span to make admission controller-induced latency visible via traces.
Link to tracking Issue: open-telemetry/otel-arrow#244 previous effort, I forgot I had moved this package to contrib. 😁
Testing: ✅