Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/httpcheck] Add DNS Duration Timing Metric #34989

Closed
wants to merge 3 commits into from

Conversation

StephanSalas
Copy link

Description: Add a DNS Duration Timing Metric to ensure that the DNS Timing is measured if the "endpoint" configuration variable is a FQDN/Host. This allows for more detailed measurements within the total http Layer-7 call flow. This also helps developers understand the latency distribution between the DNS Portion of Layer7, and all the other components.

Link to tracking Issue: #34987

Testing: Automated Tests need to be added

Documentation: Documentation is auto-generated, however README.MD needs to be updated for this component to ensure that DNS Metric is called out / documented.

@StephanSalas StephanSalas requested a review from a team September 3, 2024 19:35
Copy link

linux-foundation-easycla bot commented Sep 3, 2024

CLA Missing ID CLA Not Signed

@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Sep 3, 2024
@crobert-1
Copy link
Member

Hello @StephanSalas, for this PR to be able to be reviewed, the EasyCLA check must pass. It looks like your commits were done with a different email address than what your GitHub account is using.

@StephanSalas
Copy link
Author

Hello @StephanSalas, for this PR to be able to be reviewed, the EasyCLA check must pass. It looks like your commits were done with a different email address than what your GitHub account is using.

Agreed! I think the only commit that is conflicting is the merge commit, which is commited by other devs. May have to redo this PR and remove that merge commit from upstream.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/httpcheck HTTP Check receiver Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants