Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify google managed prometheus troubleshooting guide #34986

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 3, 2024

Description:

Adding all resource attributers as metric labels can produce more problems than it solves if, for example, resource attributes are too long.

Fixes GoogleCloudPlatform/opentelemetry-operations-go#887

Instead, recommend adding a set of common known identifying attributes.

@dashpole dashpole requested review from a team and djaglowski September 3, 2024 16:59
@github-actions github-actions bot added the exporter/googlemanagedprometheus Google Managed Prometheus exporter label Sep 3, 2024
@dashpole dashpole added the documentation Improvements or additions to documentation label Sep 3, 2024
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 3, 2024
@codeboten codeboten merged commit a0ea89c into open-telemetry:main Sep 4, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 4, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…ry#34986)

Adding all resource attributers as metric labels can produce more
problems than it solves if, for example, resource attributes are too
long.

Fixes
GoogleCloudPlatform/opentelemetry-operations-go#887

Instead, recommend adding a set of common known identifying attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation exporter/googlemanagedprometheus Google Managed Prometheus exporter Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document lack of support for deny listing in resource_filters (or add support).
4 participants