[receiver:awsfirehosereceiver] added support for OTLP v1.0.0 format #34982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
7 times, most recently
from
1cfd813
to
ec9b6fc
Compare
Aneurysm9
reviewed
Sep 6, 2024
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
receiver/awsfirehosereceiver/internal/unmarshaler/otelmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
2 times, most recently
from
842dbe7
to
c910564
Compare
vihangvk
changed the title
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
7 times, most recently
from
de3e1b3
to
12aedd1
Compare
Aneurysm9
reviewed
Sep 13, 2024
receiver/awsfirehosereceiver/internal/unmarshaler/otlpmetricstream/unmarshaler.go
Outdated
Show resolved
Hide resolved
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
from
12aedd1
to
a197824
Compare
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
2 times, most recently
from
e8a6e7a
to
9fcb7aa
Compare
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
4 times, most recently
from
fa0ec51
to
a5ddedd
Compare
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
from
a5ddedd
to
bb3fcd1
Compare
Aneurysm9
approved these changes
Oct 9, 2024
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
from
bb3fcd1
to
a84f79d
Compare
|
@Aneurysm9 Thanks for approving the PR but had to rebase due to conflicting upstream changes. |
|
@mx-psi could you please help approve and merge this PR? |
mx-psi
approved these changes
Oct 10, 2024
|
Looks like you need to regenerate the code by running |
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
from
a84f79d
to
c8b3a58
Compare
vihangvk
force-pushed
the
feature/awsfirehosereceiver_otelformat_support
branch
from
c8b3a58
to
f3fb95c
Compare
@mx-psi Thanks! Ran |
|
@mx-psi Checks are passed, could you please help merge the PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added support for OpenTelemetry 1.0.0 format
Current implementation for
awsfirehosereceiversupports only JSON format.Added support to handle OpenTelemetry 1.0.0 format.
Standard OpenTelemetry receiver does not work as AWS Cloudwatch metrics are streamed via AWS Firehose stream. So the actual OpenTelemetry data is embedded in AWS Firehose records.
This can be enabled in configuration by setting
record_typetootlp_v1. (Added suffix v1 as AWS CloudWatch metrics streaming also supports OpenTelemetry 0.7.0 format).Unmarshalerunder new packageotlpmetricstream.defaultMetricsUnmarshalersinfactory.goto create instance of new Unmarshaler.availableRecordTypesto support the OpenTelemetry 1.0.0 format.Testing: Added test cases to test new Unmarshler to test record unmarshaling.
Documentation: Updated readme to document new
record_type.