Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/k8sattributes] Update README.md #34950

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

joegoldman2
Copy link
Contributor

Link to tracking Issue: N/A

Testing: N/A

Documentation:

Update README for Kubernetes Attributes Processor to indicate container.id attribute is available if k8s.container.name is provided.
I followed https://docs.appdynamics.com/observability/cisco-cloud-observability/en/application-performance-monitoring/monitor-applications-in-kubernetes/infrastructure-correlation#InfrastructureCorrelation-KubernetesPodContainerID and it's working.

cc @iskiselev

@songy23 songy23 added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 3, 2024
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Sep 4, 2024
@TylerHelmuth TylerHelmuth removed the ready to merge Code review completed; ready to merge by maintainers label Sep 5, 2024
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Sep 20, 2024
@codeboten codeboten merged commit 488a79b into open-telemetry:main Sep 26, 2024
138 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 26, 2024
@joegoldman2 joegoldman2 deleted the patch-1 branch September 26, 2024 16:53
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
**Documentation:**

Update README for Kubernetes Attributes Processor to indicate
`container.id` attribute is available if `k8s.container.name` is
provided.
I followed
https://docs.appdynamics.com/observability/cisco-cloud-observability/en/application-performance-monitoring/monitor-applications-in-kubernetes/infrastructure-correlation#InfrastructureCorrelation-KubernetesPodContainerID
and it's working.

cc @iskiselev

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation processor/k8sattributes k8s Attributes processor ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants