Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all components for testbed #34949

Closed
wants to merge 1 commit into from

Conversation

swamisriman
Copy link
Contributor

@swamisriman swamisriman commented Sep 1, 2024

Description:
Adding all components from otelcontribcol to oteltestbedcol.

Link to tracking Issue:
Resolves #33193

Testing:
When using the following processors in tests/resource_processor_test.go/TestMetricResourceProcessor(...), the test passes.
See the linked issue for context.

processors := map[string]string{
				"resource":  test.resourceProcessorConfig,
				"transform": "\n  transform:\n",
			}

@MovieStoreGuy MovieStoreGuy added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 2, 2024
@rogercoll
Copy link
Contributor

Do we want to add all the components to the binary even if they are not used in the tests/testbed package? What would be the benefit?

@rogercoll
Copy link
Contributor

Should we update the contributing guides accordingly? New components should be added to the binary too: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

@swamisriman
Copy link
Contributor Author

What would be the benefit?

@rogercoll
I feel that it would keep the experience consistent across otelcontribcol and oteltestbedcol.

Users of the OpenTelemetry Collector are also encouraged to build their own custom distributions with the OpenTelemetry Collector Builder, using the components they need from the core repository, the contrib repository, and possibly third-party or internal repositories.

Taken from repo README.
I think the same principle applies here.

Also, I don't think we are publishing any pre-built testbed binaries (are we??)

@rogercoll
Copy link
Contributor

Another approach would be to remove the testbed binary in favor of the otelcolcontrib one, related PR: #34849

@swamisriman
Copy link
Contributor Author

oh...yeah
that would be even neater - to use the same contrib binary for tests too.

@swamisriman
Copy link
Contributor Author

swamisriman commented Sep 7, 2024

So, what do you say guys?
Shall we skip this in favour of #34849 ?
Or will this be an interim solution?

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 3, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/oteltestbedcol Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testbed not working with transform processor in config
4 participants