-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding all components for testbed #34949
Conversation
Do we want to add all the components to the binary even if they are not used in the |
Should we update the contributing guides accordingly? New components should be added to the binary too: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components |
@rogercoll
Taken from repo README. Also, I don't think we are publishing any pre-built testbed binaries (are we??) |
Another approach would be to remove the testbed binary in favor of the otelcolcontrib one, related PR: #34849 |
oh...yeah |
So, what do you say guys? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Adding all components from otelcontribcol to oteltestbedcol.
Link to tracking Issue:
Resolves #33193
Testing:
When using the following processors in tests/resource_processor_test.go/TestMetricResourceProcessor(...), the test passes.
See the linked issue for context.