make update-otel #34694
Merged
make update-otel #34694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mx-psi could you have a look at this? I think it should solve the problem with |
mx-psi
approved these changes
Sep 10, 2024
codeboten
approved these changes
Sep 10, 2024
mx-psi
added
the
ready to merge
|
This was a step in the right direction, but it looks like there are still a couple manual steps left. For example, Another cumbersome thing is replacing the |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** <Issue number if applicable> - Resolves open-telemetry#21632 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> So at first i reordered the `update-otel` command, because there was no sense in first updating the builder-configs (with the use of go.mod file) and then updating `go.mod`-files. Furthermore since the main `go.mod`-file has moved: open-telemetry@cfd83af#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 I changed the source-file to `cmd/otelcontribcol/go.mod`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation:
So at first i reordered the
update-otelcommand, because there was no sense in first updating the builder-configs (with the use of go.mod file) and then updatinggo.mod-files.Furthermore since the main
go.mod-file has moved:cfd83af#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
I changed the source-file to
cmd/otelcontribcol/go.mod