Allow specifying name on the connection to RabbitMQ

[snichme]

Description:

Allow specifying name on the connection to RabbitMQ

Link to tracking Issue: 34681

Testing:

Locally tested by changing the name of the connection in the config file and see that it changes in the broker.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: snichme / name: Magnus Landerblom (cc42c43, 6b9370d, c55fd7a, f46376f, 2d0b669, 2440c81)

[swar8080]

Thanks, it'd also be helpful to update the README with the new config option

[snichme]

@swar8080 added name as config option and also noted that the configuration appears to have wrong indentation, routing isn't under connnection or am I missing something? WDYT?

[swar8080]

@swar8080 added name as config option and also noted that the configuration appears to have wrong indentation, routing isn't under connnection or am I missing something? WDYT?

Thanks for fixing the indentation

[snichme]

What is the next step to get this merged?

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[snichme]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

thats not good, what are the missing steps to get this merged?

[swar8080]

Hi @snichme, the pipeline's blocked because there isn't a changelog. It's pretty quick to add, see https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

[snichme]

Will fix the changelog and have a look at tests

Another question, is there a way to mark a field as optional in the config. Because now it's a breaking change where the collector wont start if you supply a name, would be nice if the given name was used if available, otherwise use the default so we keep backwards compatibility.

[snichme]

Added a changelog entry as enhancement but unless we can make the setting optional I would consider this a breaking change.
So either change the changelog or the make the setting optional (if that is possible) WDYT?

[snichme]

Never mind about the optional settings. It works just as it is and this change is just an enhancement

[snichme]

@swar8080 changelog added now

[snichme]

@swar8080 merge is still blocked and some checks haven't run on the PR, is there anything I can do to get this merged?