Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Restore Lint on Windows #34656

Merged
merged 10 commits into from
Aug 14, 2024
Merged

[chore] Restore Lint on Windows #34656

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ded4812
Restore Lint on Windows
pjanotti Aug 13, 2024
7d7b88b
Build of local tools should ignore GOOS
pjanotti Aug 13, 2024
40299d4
Lint fixes
pjanotti Aug 13, 2024
eedc984
Merge branch 'main' into restore-lint-on-windows
pjanotti Aug 13, 2024
6d20d59
Note for API casing change
pjanotti Aug 14, 2024
fa38542
Merge branch 'main' into restore-lint-on-windows
pjanotti Aug 14, 2024
c5f2651
Merge branch 'main' into restore-lint-on-windows
pjanotti Aug 14, 2024
39b3981
Merge branch 'main' into restore-lint-on-windows
pjanotti Aug 14, 2024
b92a1a5
Lint fixes for receiver/iis tests
pjanotti Aug 14, 2024
af0650e
Merge branch 'main' into restore-lint-on-windows
pjanotti Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Restore Lint on Windows
  • Loading branch information
@pjanotti
pjanotti committed Aug 13, 2024
commit ded4812332d5a5b895d69e0c9c4faa6054597421
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test:
goos:
- windows
- linux
group:
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
path: ~/.cache/go-build
key: go-lint-build-${{ matrix.group }}-${{ runner.os }}-${{ hashFiles('**/go.sum') }}
- name: Lint
run: GOOS=${{ matrix.os }} GOARCH=amd64 make -j2 golint GROUP=${{ matrix.group }}
run: GOOS=${{ matrix.goos }} GOARCH=amd64 make -j2 golint GROUP=${{ matrix.group }}
lint:
if: ${{ github.actor != 'dependabot[bot]' && always() }}
runs-on: ubuntu-latest
Expand Down
Loading