Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/bearertokenauth] use constant time comparison #34516

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[extension/bearertokenauth] use constant time comparison #34516

merged 2 commits into from
Aug 8, 2024

Commits on Aug 8, 2024

  1. [extension/bearertokenauth] minor improvements 

    - clarify error message in case of missing header
- don't use implementation code to verify expectations in tests
- format header value ahead of time, rather than on every use,
  to avoid allocations
- consistently synchronise access to header value for both client and
  server authenticators (now using sync/atomic.Value rather than RWMutex)
    @axw @codeboten
    axw authored and codeboten committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c269413 View commit details
    Browse the repository at this point in the history

  2. changelog 

    Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
    @codeboten
    codeboten committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2d6f02b View commit details
    Browse the repository at this point in the history