Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/rabbitmqreceiver] update scope name for consistency #34475

Conversation

codeboten
Copy link
Contributor

Update the scope name for telemetry produced by the rabbitmqreceiverreceiver from otelcol/rabbitmqreceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiverreceiver

Part of open-telemetry/opentelemetry-collector#9494

Update the scope name for telemetry produced by the rabbitmqreceiverreceiver from otelcol/rabbitmqreceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiverreceiver

Part of open-telemetry/opentelemetry-collector#9494

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team August 7, 2024 14:53
component: rabbitmqreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Update the scope name for telemetry produced by the rabbitmqreceiver from otelcol/rabbitmqreceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: Update the scope name for telemetry produced by the rabbitmqreceiver from otelcol/rabbitmqreceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiver
note: Update the scope name for telemetry produced by the rabbitmqreceiver from `otelcol/rabbitmqreceiver` to `github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiver`

Nit: It might be a bit more clear in the rendered MD if we add the formatting. Not a big deal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up merging these changes with a PR to all the changelogs thus far. Less CI runs that way 🤣

@codeboten codeboten merged commit e96d3b3 into open-telemetry:main Aug 7, 2024
154 checks passed
@codeboten codeboten deleted the codeboten/update-scope-rabbitmqreceiver branch August 7, 2024 15:29
@github-actions github-actions bot added this to the next release milestone Aug 7, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…elemetry#34475)

Update the scope name for telemetry produced by the
rabbitmqreceiverreceiver from otelcol/rabbitmqreceiver to
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiverreceiver

Part of
open-telemetry/opentelemetry-collector#9494

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants