Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch] Enable more index metrics by default #34397

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Aug 2, 2024

Description:

This enables the following metrics by default:

elasticsearch.index.documents
elasticsearch.index.operations.merge.current
elasticsearch.index.segments.count

Link to tracking Issue:
Resolves #34396

Testing:
Tests have been updated to account for these metrics being enabled by default. One thing to note, some tests were manually enabling these metrics. This is no longer necessary, but I've left as-is since it doesn't do any harm, and can be helpful to ensure tests act the way we want. I can update though if reviewers prefer.

Testing side note: For some reason, when running integration tests locally, I had to add a time.Sleep call before scraping when the docker container was being spun up. Some metrics and resource attributes weren't populated fully without the delay, and caused a mismatch with the GitHub CI's results that are generated without the sleep call.

@crobert-1 crobert-1 marked this pull request as draft August 2, 2024 21:39
@crobert-1 crobert-1 marked this pull request as ready for review August 3, 2024 00:18
@djaglowski djaglowski merged commit d79b8ef into open-telemetry:main Aug 5, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/elasticsearch] Request to enable more metrics by default
5 participants