[chore] nopHost for k8s cluster receivers #34334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation exposing GetExporters
TylerHelmuth
approved these changes
Jul 30, 2024
mwear
approved these changes
Jul 30, 2024
crobert-1
approved these changes
Jul 30, 2024
JaredTan95
approved these changes
Jul 31, 2024
|
@crobert-1 the tests cancelled the first time, so I reran them and didn't see them complete. I will take a look and add to this PR, thanks --- EDIT: actually, I think it might make more sense to merge this and follow up separately. |
povilasv
approved these changes
Jul 31, 2024
crobert-1
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See open-telemetry/opentelemetry-collector#10717 as the original PR for this issue.
This change removes the dependency of k8sclusterreceiver tests on nopHost, which will no longer support GetExporters in the future.