Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/splunk] Splunk metric names should be validated via regex #34291

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

spiffyy99
Copy link
Contributor

Description: For the splunk HEC receiver, add additional criteria for the metric names. As per https://docs.splunk.com/Documentation/Splunk/9.2.1/Metrics/Overview#What_is_a_metric_data_point.3F, metric names can only consist of specific characters. Validates these requirements to be in line with other Splunk receivers.

Link to tracking Issue: #34275

Testing: Unit tests

Documentation: N/A

@spiffyy99 spiffyy99 requested a review from dmitryax as a code owner July 29, 2024 15:18
@spiffyy99 spiffyy99 requested a review from a team July 29, 2024 15:18
Copy link

linux-foundation-easycla bot commented Jul 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

internal/splunk/common.go Outdated Show resolved Hide resolved
@spiffyy99 spiffyy99 force-pushed the add-splunk-metric-name-rules branch from d4f73a5 to b2fa86c Compare July 29, 2024 16:47
@dmitryax dmitryax merged commit f01613a into open-telemetry:main Jul 30, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants