[internal/otelarrow] [chore] fix TestMRUReset flakiness #34260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the monotonic clock has advanced prior to resetting, to ensure the item generation is before the reset.
(Was planning to add a greater-than check on the generations, but ended up deciding against it.)
crobert-1
approved these changes
Jul 30, 2024
mx-psi
pushed a commit
that referenced
this pull request
Aug 6, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This reverts #34362 as #34260 was merged to resolve the test. The flakiness should be resolved so we no longer need to skip this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure the monotonic clock has advanced prior to resetting, to ensure the item generation is before the reset.
The monotonic clock is guaranteed to be non-decreasing, but may be identical in consecutive measurements.
Link to tracking Issue:
#34252
Testing:
I couldn't reproduce the issue locally - this issue would depend on the system clock frequency.
Documentation:
N/A