Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otelarrow/netstats] prefix metrics with otelcol_ #34198

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[otelarrow/netstats] prefix metrics with otelcol_ #34198

merged 3 commits into from
Jul 22, 2024

Conversation

codeboten
Copy link
Contributor

This used to be automatically added previously via the prometheus exporter's WithNamespace configuration. That has been removed in open-telemetry/opentelemetry-collector#9759

@codeboten
[otelarrow/netstats] prefix metrics with otelcol_
7b0db89 
This used to be automatically added previously via the prometheus exporter's WithNamespace configuration. That has been removed in open-telemetry/opentelemetry-collector#9759

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from jmacd as a code owner July 22, 2024 20:14
@codeboten codeboten requested review from a team and mwear July 22, 2024 20:14
@github-actions github-actions bot requested a review from moh-osman3 July 22, 2024 20:14
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 22, 2024
jmacd
jmacd approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the exporter and receiver READMEs name these metrics the way they were. I don't mind the change, but we should fix receiver/otelarrowreceiver/README.md and exporter/otelarrowexporter/README.md.

@codeboten
fix test
7712668 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
update readmes
765e07a 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
Copy link
Contributor Author

readme's updated as well

@github-actions github-actions bot requested a review from lquerel July 22, 2024 21:33
@codeboten codeboten merged commit 9da7fea into open-telemetry:main Jul 22, 2024
156 checks passed
@codeboten codeboten deleted the codeboten/prefix-otelarrow-netstats branch July 22, 2024 21:53
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@jmacd jmacd jmacd approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

@lquerel lquerel Awaiting requested review from lquerel

Assignees

@TylerHelmuth TylerHelmuth

Labels
exporter/otelarrow internal/otelarrow receiver/otelarrow Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging this pull request may close these issues.
4 participants
@codeboten @mwear @jmacd @TylerHelmuth