Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Remove deprecated peer_service_aggregation #34177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[exporter/datadog] Remove deprecated peer_service_aggregation #34177

wants to merge 4 commits into from

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jul 19, 2024

Config peer_service_aggregation has been deprecated in favor of peer_tags_aggregation since v0.89

@github-actions github-actions bot added the exporter/datadog Datadog components label Jul 19, 2024
@songy23 songy23 marked this pull request as ready for review July 19, 2024 19:23
@songy23 songy23 requested a review from a team July 19, 2024 19:23
mx-psi
mx-psi requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to removed settings?

opentelemetry-collector-contrib/exporter/datadogexporter/config.go

Line 546 in dba8f51

var removedSettings = []renameError{

@songy23
Copy link
Member Author

songy23 commented Jul 22, 2024

Added to removedSettings

@songy23 songy23 mentioned this pull request Jul 23, 2024
Merged
@songy23 songy23 added the never stale Issues marked with this label will be never staled and automatically removed label Jul 24, 2024
@songy23
Copy link
Member Author

songy23 commented Jul 24, 2024

Discussed in another PR, going to put this PR on hold for now.

@mx-psi mx-psi added the on hold This is blocked by another PR/issue label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi requested changes

@dineshg13 dineshg13 dineshg13 approved these changes

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

Requested changes must be addressed to merge this pull request.

Assignees

@mx-psi mx-psi

Labels
exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed on hold This is blocked by another PR/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @dineshg13 @mx-psi