[processor/deltatocumulative]: mdatagen telemetry #33981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
force-pushed
the
deltatocumulative-telemetry-mdatagen
branch
from
7a9ce86
to
929410c
Compare
|
no changelog needed imo |
|
Looks like some linting is still needed. Please update the description to include the following to automatically close the issue: Fixes #33573 |
sh0rez
force-pushed
the
deltatocumulative-telemetry-mdatagen
branch
from
9a55620
to
20f4d71
Compare
Uses recently introducted `telemetry:` feature of `mdatagen` to define the internal telemetry exported from this component. Leaves the general `telemetry` package in-place, as it also does error handling (for now). Changing so requires a deeper refactor that will be done later
sh0rez
force-pushed
the
deltatocumulative-telemetry-mdatagen
branch
from
846bdb5
to
f69f4cb
Compare
codeboten
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses recently introducted
telemetry:feature ofmdatagento define the internal telemetry exported from this component.Leaves the general
telemetrypackage in-place, as it also does error handling (for now). Changing so requires a deeper refactor that will be done laterLink to tracking Issue:
Fixes #33573
Testing: not needed
Documentation: changed to auto-generated