[chore] alternative for splunkhec to use otel #33924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to open-telemetry#33664, since mdatagen doesn't support changing metric names, this substitutes the opencensus sdk calls with otel directly. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
This looks like the right approach to me. Sorry I didn’t get to it myself and thank you for pursuing this! |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
@atoulme this is ready for review now, PTAL |
atoulme
approved these changes
Jul 8, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #33664, since mdatagen doesn't support changing metric names, this substitutes the opencensus sdk calls with otel directly.
Pinging @atoulme @dmitryax @crobert-1 to guide which of the two approaches is preferred. This component is the last one blocking the removal of the opencensus bridge in core.
Closes #33471
Closes #29867
NOTE: tests need to be fixed, but i wanted to propose this alternative before spending time to fix the tests