[chore] Fix loadtest setup script #33860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
evan-bradley
added
the
Skip Changelog
codeboten
approved these changes
Jul 2, 2024
mx-psi
pushed a commit
that referenced
this pull request
Jul 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR fixes more issues with the load test pipeline. Specifically, it adjusts some things around artifact up/download which is needed as a result of the breaking changes in GitHub Actions artifacts listed [here](https://github.com/actions/upload-artifact#breaking-changes:~:text=Uploading%20to%20the%20same%20named,you%20will%20encounter%20an%20error.). Also, it removes the issue generation step which seems far outdated as it's failing with missing CircleCI env variables. Also, I noticed that a few of the load tests fail consistently. To test. the pipeline, I had to comment them out. Not sure, what to do with them... **Link to tracking Issue:** Part of #33577 Follow up to #33860 **Testing:** Testing done on my personal fork. Link to working pipeline run: [Green run with some broken tests commented out, but pipeline working](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9789652148) [Red run with broken tests](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9790395589) **Documentation:** none added --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the load test pipeline which was broken for a while.
The array of tests was not iterated over correctly in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/workflows/scripts/setup_e2e_tests.sh and the first iteration of the loop resulted in the whole array being added to the matrix instead of just the first entry of the array.
I introduced a different way to read in the array of tests at the start of the setup bash script, which works now.
source for the solution
Link to tracking Issue: Fixes #33577
Testing: Tested successfully on my personal fork. This is a link to a load test run where the matrix is correctly parsed by github actions.
Documentation: nothing to document