Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/gelfreceiver] Added Support for GELF log receiver. #33858

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

BharatKJain
Copy link

@BharatKJain BharatKJain commented Jul 2, 2024

Description:

Added support for GELF based logs - please read this document to understand GELF implementation.

Tremor's implementation for GELF receiver

Otel-collector's GELF implementation document: https://docs.google.com/document/d/1P9JcrXrORqI0wsnRgrcUroluutf3rVrcUCIgLeSpFm0/edit?usp=sharing

Link to tracking Issue: #33861

Testing:

  • Tested the functionality of the code locally.
  • Will create the unit-tests for it.

Documentation: Work-in-progress.

@BharatKJain BharatKJain requested a review from a team July 2, 2024 13:00
Copy link

linux-foundation-easycla bot commented Jul 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command pkg/stanza labels Jul 2, 2024
@BharatKJain BharatKJain changed the title Added Support for GELF log receiver. [receiver/gelfreceiver] Added Support for GELF log receiver. Jul 2, 2024
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to accept a new component you must formally propose it in an issue and find a sponsor.

@BharatKJain
Copy link
Author

BharatKJain commented Jul 4, 2024

In order to accept a new component you must formally propose it in an issue and find a sponsor.

@djaglowski I don't have a sponsor, is it possible for you to help with that part? or is there a process to get sponsor, then please share the readme/doc for it?

I know about the list of sponsors mentioned here: Link - but how do I ask someone to become sponsor/reviewer for this PR? I guess it's voluntary so I cannot really ask randomly.

Also there's a Slack thread running for it, we can communicate there as well: thread link

@djaglowski
Copy link
Member

I don't have capacity to voluntarily sponsor any additional components. Hopefully someone else is interested. Otherwise, you can always host the component elsewhere and others can still build it into their collectors using the Collector Builder.

@BharatKJain
Copy link
Author

BharatKJain commented Jul 9, 2024

@djaglowski Instead of creating a separate receiver, if I add this as a part of UDP receiver then will that be okay in terms of sponsorship as you're the contributor? GELF will be like a CODEC.

@djaglowski
Copy link
Member

I don't believe GELF support should be a concern of the UDP receiver.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 24, 2024
@github-actions github-actions bot removed the Stale label Aug 6, 2024
Copy link
Contributor

@hughesjj hughesjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tests, could you please add some to ensure the receiver works as expected?

cmd/otelcontribcol/builder-config.yaml Outdated Show resolved Hide resolved
cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
pkg/stanza/operator/input/gelfinternal/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 28, 2024
@atoulme atoulme added the Sponsor Needed New component seeking sponsor label Sep 5, 2024
@github-actions github-actions bot removed the Stale label Sep 5, 2024
@BharatKJain
Copy link
Author

BharatKJain commented Sep 12, 2024

I don't see any tests, could you please add some to ensure the receiver works as expected?

@hughesjj I tried talking to folks in SIG otel-collector meeting, they said that we need sponsor for this PR and that it won't be accepted unless there's someone sponsoring this, so before I spend more effort on it - wanted to know if you would be able to sponsor this PR or get this accepted given that all comments are fixed?

I don't want my efforts to go into vain. 😞

(Also I didn't realize there were more comments, sorry for the late response, missed notifications on it.)

cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
}

if c.ListenAddress == "" {
return nil, fmt.Errorf("missing required parameter 'listen_address'")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return nil, fmt.Errorf("missing required parameter 'listen_address'")
return nil, errors.New("missing required parameter 'listen_address'")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but if you check ../udp/config.go, they are using fmt...I didn't wanted to diverge from it, let me know your thoughts.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 3, 2024
@BharatKJain BharatKJain requested a review from a team as a code owner October 7, 2024 06:41
@BharatKJain BharatKJain force-pushed the gelf-receiver-operator branch 3 times, most recently from 771b589 to c9942ee Compare October 7, 2024 10:15
@BharatKJain
Copy link
Author

  • Added the suggested fixes, please re-check once.
  • Added unit-test, will add more in sometime

Let me know if there's anything else!

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command pkg/stanza Sponsor Needed New component seeking sponsor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants