Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compile pipeline job building for ARM 7 #33830

Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Jul 1, 2024

Description:
This PR fixes a small issue in the cross-compile pipeline job. #23436 aimed to introduce a new specific matrix configuration that built for linux/arm with ARMv7 but accidentally built all arm jobs with ARMv7 with some magic of YAML and GitHub actions matrix definitions 😇

Link to tracking Issue: #29542

Testing: not sure how to test, since this is just pipeline changes

Documentation: no docs added

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies requested review from a team and dashpole July 1, 2024 14:55
@mx-psi mx-psi requested review from atoulme and crobert-1 July 1, 2024 15:03
@crobert-1 crobert-1 added Skip Changelog PRs that do not require a CHANGELOG.md entry ci-cd CI, CD, testing, build issues labels Jul 1, 2024
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your investigation and for fixing, @mowies!

@TylerHelmuth TylerHelmuth merged commit 859d04b into open-telemetry:main Jul 1, 2024
165 of 167 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 1, 2024
@mowies mowies deleted the fix-linux-arm-7 branch July 2, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] opentelemetry-collector-contrib builds linux/arm64 binary with wrong arm version
5 participants