-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #33464 [processor/groupbytrace] migrate from opencensus library #33770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @honeychaudharyc, please sign the CLA and we can get this reviewed
|
||
The following telemetry is emitted by this component. | ||
|
||
### processor_groupbytrace_conf_num_traces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have an otelcol_ prefix to this metric today. We need to ensure that we are not introducing a breaking change to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prometheus exporter configuration prepends that prefix automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this under the assumption that the metrics before and after this change are the same from the user's perspective.
…encensus library This migrates internal metrics from opencensus to mdatagen + otel. Used metadata.Telemetrybuilder and replaced all metrices from metrics file to metadata.yaml file. Updated tests to move from opencensus. Documentation generated by metadata.yaml file
Metrics before the change:
After the change:
|
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Brought back the metric test that was looking at the gauge values using otel instead of opencensus. This should be ready to go now |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This PR migrates the internal metrics from opencensus for the groupbytrace processor to Opentelemetry for metrics, via mdatagen. Used metadata.Telemetrybuilder and replaced all metrices from metrics file to metadata.yaml file. Updated tests to move from opencensus.
Fixes #33464
Testing: Unit tests
Documentation: Documentation generated by metadata.yaml.