-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32669 wireframe sum connector #33759
Merged
mx-psi
merged 24 commits into
open-telemetry:main
from
greatestusername:32669-wireframe-sum
Jul 3, 2024
Merged
32669 wireframe sum connector #33759
mx-psi
merged 24 commits into
open-telemetry:main
from
greatestusername:32669-wireframe-sum
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Jun 25, 2024
crobert-1
reviewed
Jun 27, 2024
crobert-1
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the configuration details, super helpful 👍 Just some questions and clarifications.
crobert-1
reviewed
Jul 2, 2024
crobert-1
approved these changes
Jul 2, 2024
crobert-1
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready to merge
Code review completed; ready to merge by maintainers
reports/distributions/contrib.yaml
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Initial wireframe PR for a new sum connector (as described in #32669)
Provides bare minimum to start developing a new connector (config, factory, integration test stubs for connector lifecycle, etc)
Sum Connector takes in logs, metrics, or traces and matches an attribute then allows summing numerical values present in that attribute and sending those sums as a time series metric along with any attributes defined within the connector config.
E.G. Log contains a field for
total_price
of a payment. Matching ontotal_price
as thesource_attribute
will take numerical values from this attributte and emit a time series metric (checkout.total
) of the sums along with any other attributes defined in the connector config.Example config:
Link to tracking Issue: 32669
Testing: Generated component and package tests
Documentation: README and issue #32669 provide current documentation of projected future state.