[receiver/windowsperfcounters] Clarify current treatment of the _Total instance
#33692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alxbl @crobert-1 |
pjanotti
changed the title
_Total instance_Total instance
pjanotti
commented
Jun 21, 2024
| metric: processor.time.total | ||
| ``` | ||
|
|
||
| > [!WARNING] |
There was a problem hiding this comment.
This actually gives an idea to how better handle counters that don't use _Total for their aggregation. We can have a configuration called something like aggregation_name, that by default is _Total, if someone is using a counter that uses a different name for the aggregation instance we let them specify so the problem of double counting can be easily solved.
There was a problem hiding this comment.
The aggregation_name would be used to decide which instance to drop from a wildcard collection? That makes sense to me.
There was a problem hiding this comment.
Yes, so it keeps the current default behavior, but, if some user wants to drop the _Global_ they add that to the configuration.
alxbl
approved these changes
Jun 21, 2024
crobert-1
added
Skip Changelog
Co-authored-by: Curtis Robert <crobert@splunk.com>
…n' of github.com:pjanotti/opentelemetry-service-contrib into windows-perf-counters-aggregation-instance-clarification
crobert-1
approved these changes
Jun 21, 2024
crobert-1
added
the
ready to merge
dmitryax
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Clarifies the current treatment of the
_Totalinstances.Link to tracking Issue:
Fix #29054
Testing:
Manually validated the configuration added to the README.md
Documentation:
Described the behavior of the
_Totalinstance as currently implemented.