Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/statsdreceiver] allow changing percentiles for summary types #33674

Merged
merged 1 commit into from
Jul 14, 2024
Merged

[receiver/statsdreceiver] allow changing percentiles for summary types #33674

merged 1 commit into from
Jul 14, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jun 20, 2024 •
edited
Loading

Description:

Allow selecting percentiles when using summary type:

receivers:
  statsd:
    endpoint: "0.0.0.0:8125"
   ...
    timer_histogram_mapping:
      - statsd_type: "timing"
        observer_type: "summary"
        summary: 
          percentiles: [0, 10, 50, 90, 95, 99, 100]

Link to tracking Issue:

#33701

Testing:

  • local tests
  • unit tets

Documentation:

  • updated

@github-actions github-actions bot added the receiver/statsd statsd related issues label Jun 20, 2024
@github-actions github-actions bot requested review from dmitryax and jmacd June 20, 2024 12:53
@povilasv povilasv marked this pull request as ready for review June 21, 2024 10:15
@povilasv povilasv requested a review from a team June 21, 2024 10:15
@povilasv
Copy link
Contributor Author

gentle ping @jmacd / @dmitryax

dmitryax
dmitryax approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 8644901 into open-telemetry:main Jul 14, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 14, 2024
@povilasv povilasv deleted the statsd-percentiles branch July 15, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

Assignees

@fatsheep9146 fatsheep9146

Labels
receiver/statsd statsd related issues
Projects
None yet
Milestone
v0.105.0
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @dmitryax @fatsheep9146