-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Support preserving attributes when mapping to ECS #33670
[exporter/elasticsearch] Support preserving attributes when mapping to ECS #33670
Conversation
…o ECS Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context on the history of these two fields can be seen in elastic/ecs#144 (comment).
Since there is no such distinction in SemConv right now, it does makes sense to preserve both.
➕ on this.
SemConv says: "...On Unix ... contain what hostname ... returns, or the fully qualified hostname, or another name specified by the user." -> In ECS user specified would be host.name
, otherwise either host.name
or host.hostname
. But we don't know from OTel data if it's user specified or not, so I agree, best is to populate both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (one comment on the changelog).
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Description:
This PR adds support for preserving resource attributes that are valid ECS fields in addition of mapping them. At the moment the
host.name
is mapped to thehost.hostname
. Both are valid ECS fields but can differ in some cases. Since there is no such distinction in SemConv right now, it does makes sense to preserve both.refs:
Link to tracking Issue:
Testing:
Using the testing notes from #33622.
Stored document:
Documentation: ~
/cc @lahsivjar @andrzej-stencel @carsonip