[chore][receiver/hostmetrics] replace unmaintained library github.com/leoluk/perflib_exporter
#33653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connector/datadog
exporter/datadog
github-actions
bot
requested review from
ankitpatel96,
braydonk,
dineshg13,
liustanley and
mackjmr
andrzej-stencel
force-pushed
the
replace-perflib-library
branch
from
457d759 to
1455917
Compare
…m/leoluk/perflib_exporter` Fixes open-telemetry#33652
andrzej-stencel
force-pushed
the
replace-perflib-library
branch
from
a64e8d4 to
fe6c384
Compare
mx-psi
approved these changes
Jun 19, 2024
braydonk
approved these changes
Jun 19, 2024
codeboten
approved these changes
Jun 19, 2024
@andrzej-stencel if you have performance improvement measurements, i would certainly add this as an enhancement to the changelog :) |
songy23
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This replaces
perflibpackage from the unmaintained library https://github.com/leoluk/perflib_exporter withperflibpackage from https://github.com/prometheus-community/windows_exporter.The added benefit of this update is a potential collector startup time improvement, as there's initialization code removed: prometheus-community/windows_exporter@11218a9.
I wonder if this change should be mentioned in the Changelog? 🤔
Link to tracking Issue:
github.com/leoluk/perflib_exporter#33652Testing:
No changes.
Documentation:
No changes.