Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update solace receiver to use mdatagen #33582

Merged

Conversation

codeboten
Copy link
Contributor

This updates the code that was using OpenCensus to use mdatagen + otel

Fixes #33468

This updates the code that was using OpenCensus to use mdatagen + otel

Fixes open-telemetry#33468

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten force-pushed the codeboten/solacereceiver-mdatagen branch from c26fcae to 4313f37 Compare June 19, 2024 00:13
@codeboten codeboten marked this pull request as ready for review June 19, 2024 00:13
@codeboten codeboten requested a review from a team June 19, 2024 00:13
@codeboten
Copy link
Contributor Author

@oodigie @mcardy would love a review, this is one of 6 PRs left to migrate away from opencensus in contrib

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten changed the title [wip][chore] update solace receiver to use mdatagen [chore] update solace receiver to use mdatagen Jun 19, 2024
Copy link
Contributor

@mcardy mcardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. mdatagen looks much cleaner!

@codeboten codeboten merged commit 5bf038c into open-telemetry:main Jun 21, 2024
154 checks passed
@codeboten codeboten deleted the codeboten/solacereceiver-mdatagen branch June 21, 2024 18:25
@github-actions github-actions bot added this to the next release milestone Jun 21, 2024
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Jun 24, 2024
This updates the code that was using OpenCensus to use mdatagen + otel

Fixes open-telemetry#33468

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from opencensus library: receiver/solacereceiver
4 participants