-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update solace receiver to use mdatagen #33582
Merged
codeboten
merged 5 commits into
open-telemetry:main
from
codeboten:codeboten/solacereceiver-mdatagen
Jun 21, 2024
Merged
[chore] update solace receiver to use mdatagen #33582
codeboten
merged 5 commits into
open-telemetry:main
from
codeboten:codeboten/solacereceiver-mdatagen
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the code that was using OpenCensus to use mdatagen + otel Fixes open-telemetry#33468 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/solacereceiver-mdatagen
branch
from
June 19, 2024 00:13
c26fcae
to
4313f37
Compare
codeboten
changed the title
[wip][chore] update solace receiver to use mdatagen
[chore] update solace receiver to use mdatagen
Jun 19, 2024
mcardy
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. mdatagen looks much cleaner!
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
TylerHelmuth
approved these changes
Jun 21, 2024
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Jun 24, 2024
This updates the code that was using OpenCensus to use mdatagen + otel Fixes open-telemetry#33468 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code that was using OpenCensus to use mdatagen + otel
Fixes #33468