[chore] migrate metrics to mdatagen #33514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Jun 12, 2024
ChrsMark
approved these changes
Jun 18, 2024
Added metadata.yaml file to allow for generation of internal metrics. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/mdatagen-fileconsumer-metrics-2
branch
from
b1a0354
to
b958ee1
Compare
codeboten
pushed a commit
that referenced
this pull request
Jun 20, 2024
`main` is currently failing the [`checks` action](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9588994799/job/26442043847), at the `Gen CODEOWNERS` step. This applies the required change. This was broken by #33514, which added a `metadata.yaml` file for the `pkg/stanza/fileconsumer` package, but didn't add an entry to the CODEOWNERS file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metadata.yaml file to allow for generation of internal metrics. Note the stability section of that file are not used anywhere, but mdatagen requires it.