Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/postgresql] Fixes postgresql.rows always returning 0 for state="dead" #33489

Closed
wants to merge 1 commit into from
Closed

[receiver/postgresql] Fixes postgresql.rows always returning 0 for state="dead" #33489

wants to merge 1 commit into from

Conversation

jo-goro
Copy link

@jo-goro jo-goro commented Jun 11, 2024

Description:
Fixes postgresql.rows always returning 0 for state="dead". The respective field on tableStats was never set.

Testing:
No additional tests were added.

Documentation:
No documentation was added.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 11, 2024 •
edited
Loading

CLA Not Signed

@github-actions github-actions bot requested a review from djaglowski June 11, 2024 10:14
@jo-goro jo-goro closed this Jun 11, 2024
@djaglowski djaglowski mentioned this pull request Jun 11, 2024
Merged
@djaglowski
Copy link
Member

Thanks @jo-goro. I've opened #33492 with this fix.

djaglowski added a commit that referenced this pull request Jun 11, 2024
@djaglowski
[receiver/postgresql] Fix issue where postgresql.rows metric always r…
105c3d3 
…eturned 0 for state:dead (#33492)

Replaces
#33489

Credit to @jo-goro for the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees
No one assigned
Labels
receiver/postgresql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jo-goro @djaglowski