[receiver/sqlserver] Enable more perf counter metrics #33420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Jun 6, 2024
crobert-1
commented
Jun 6, 2024
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement |
There was a problem hiding this comment.
I'm on the fence as to whether this should be considered an enhancement or breaking change. These metrics are all shown as being enabled by default, but the reality is they aren't received unless running on Windows.
This change does increase the number of metrics being received when directly connecting to the SQL server instance in reality, so let me know if we should mark this as breaking instead.
There was a problem hiding this comment.
Seems reasonable to call it an enhancement
crobert-1
force-pushed
the
sqlserver_pc_metrics
branch
from
c25f8e7
to
a35c7a1
Compare
|
Both CI/CD failures are unrelated to this change. I've added frequencies on relevant issues. |
djaglowski
approved these changes
Jun 10, 2024
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement |
There was a problem hiding this comment.
Seems reasonable to call it an enhancement
MovieStoreGuy
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These metrics already exist, and are all enabled by default, but were previously not being recorded when directly connecting to the SQL Server instance. This means these metrics will now be enabled by default across all systems and configurations.
Metrics:
Testing:
Updated tests to account for given metrics
Documentation
Updated documentation to show these metrics are now available on more systems than just Windows.