Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/kafkametrics] Fix issue with incorrect consumer offset #33336

Merged
merged 3 commits into from
Jul 14, 2024
Merged

[receiver/kafkametrics] Fix issue with incorrect consumer offset #33336

merged 3 commits into from
Jul 14, 2024

Conversation

an-mmx
Copy link
Contributor

@an-mmx an-mmx commented Jun 3, 2024 •
edited
Loading

Fixes: #33309

Description: Fix issue when consumer offset store random value

Link to tracking Issue: none

Testing: none

Documentation: none

@an-mmx an-mmx requested a review from dmitryax as a code owner June 3, 2024 10:58
@an-mmx an-mmx requested a review from a team June 3, 2024 10:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 3, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@an-mmx an-mmx changed the title [receiver/kafkametricsreceiver] Fix issue with incorrect consumer offset [receiver/kafkametrics] Fix issue with incorrect consumer offset Jun 3, 2024
@atoulme
Copy link
Contributor

atoulme commented Jun 6, 2024

Please add a changelog. Any chance you can add a test as well?

@an-mmx
Copy link
Contributor Author

an-mmx commented Jun 10, 2024

Please add a changelog. Any chance you can add a test as well?

Changelog added.
As for the tests, unfortunately, I'm not so much matur in golang.

@an-mmx an-mmx force-pushed the patch-1 branch 2 times, most recently from 7a924ba to fd296e3 Compare June 11, 2024 09:08
@an-mmx
Copy link
Contributor Author

an-mmx commented Jun 19, 2024

ping

@an-mmx
Copy link
Contributor Author

an-mmx commented Jun 25, 2024

@dmitryax ping

atoulme
atoulme approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as @samiura has reviewed and approved.

@dmitryax dmitryax merged commit ca9a8d1 into open-telemetry:main Jul 14, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiura samiura samiura approved these changes

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme atoulme approved these changes

Assignees

@dashpole dashpole

Labels
receiver/kafkametrics
Projects
None yet
Milestone
v0.105.0
Development

Successfully merging this pull request may close these issues.

[receiver/kafkametrics] Kafka consumer offset gives a random value instead of an actual offset
5 participants
@an-mmx @atoulme @dmitryax @samiura @dashpole