[exporter/kafka] Implement partitioning by resource attributes for logs #33230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHaaD94
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi @MovieStoreGuy. Could you please have a look at PR? Thank you. |
SHaaD94
force-pushed
the
partition_logs_by_resources
branch
from
3383023
to
b023168
Compare
Hi @MovieStoreGuy. Please have a look. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
MovieStoreGuy
approved these changes
Jul 30, 2024
MovieStoreGuy
added
the
ready to merge
|
Hello @MovieStoreGuy, @atoulme. Could you please help to merge the PR? Thank you. |
|
I can't merge but @MovieStoreGuy can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add resource attributes based partitioning for logs
Link to tracking Issue: #33229
Testing: Added test and tested locally
Documentation: Documented new flag.
Additionally, as discussed with @dmitryax in #31315, removed trait with Key method and refactored the code to pass flags directly to marshaller constructors. Please let me know if this way is acceptable.
I also removed an ability to add custom marshallers - option to add custom marshallers was unexposed in 0.89.0, so now the code was just sitting there unused.