[chore] exclude certain gosec linters #33192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing performance issue w/ the linters as discussed in golangci/golangci-lint#4735 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
I'll rebase after that one is merged... want to keep those two changes separate |
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 22, 2024
Same as open-telemetry/opentelemetry-collector-contrib#33192 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 22, 2024
Same as open-telemetry/opentelemetry-collector-contrib#33192 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
May 23, 2024
Same as open-telemetry/opentelemetry-collector-contrib#33192 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
…metry#10210) Same as open-telemetry/opentelemetry-collector-contrib#33192 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…metry#10210) Same as open-telemetry/opentelemetry-collector-contrib#33192 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
pushed a commit
that referenced
this pull request
Jun 14, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The upstream issue was fixed by golangci/golangci-lint#4748, which was included in release [`v1.59.0`](https://github.com/golangci/golangci-lint/releases/tag/v1.59.0) of `golangci-lint`. From local testing, we're pulling version `v1.59.1` of `golangci-lint`, so the issue should be resolved. Local runtime with excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 10.927544867s INFO Execution took 8.011302204s INFO Execution took 7.716441258s INFO Execution took 7.441336833s ``` Local runtime without excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 9.780250262s INFO Execution took 8.175492516s INFO Execution took 7.550060974s INFO Execution took 7.526585686s ``` Note: I ran `.tools/golangci-lint cache clean` between each test to clean the cache and keep results as consistent as possible. I admit that I don't know why the values keep going down with every run, the cache cleaning command may not entirely be working. **Link to tracking Issue:** <Issue number if applicable> These excludes were introduced in #33192 I've opened a PR in core for this issue as well: open-telemetry/opentelemetry-collector#10411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing performance issue w/ the linters as discussed in golangci/golangci-lint#4735