[azureeventhubreceiver] Migrate to new AzureSDK #33134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the concurrent case was broken for some reason. Regardless, the divergence in paths used is the approach strongly recommended by the SDK docs.
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
cparkins,
djaglowski and
eedorenko
github-actions
bot
added
examples/demo
exporter/alibabacloudlogservice
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cparkins
approved these changes
Jun 19, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is an enhancement to the
azureeventhubreceiver, which migrates code to use the current library as recommended by Azure in the SDK migration guide for EventHubs in Go.azureeventhubreceiverwas initially developed whenazure-event-hubs-gowas the preferred package. This has superseded by theazeventhubspackage in theAzure/azure-sdk-for-gorepo. See the migration guide for the package.Link to tracking Issue: #31252
Testing: Unit tests are updated and I have done some manual testing in development with Azure payloads.
Documentation: No additional documentation as there's no change for Collector users.