[pkg/ottl] Added 'Adding new functions/converters' guidelines #33117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
pkg/ottl/ottlfuncs/README.md
Outdated
Comment on lines
1312
to
1314
| ## Adding New Functions/Converters | ||
|
|
||
| Before raising a PR with a new function or converter, raise a PR to verify its acceptance. While acceptance is strongly specific to a specific use case, consider these guidelines for early assessment. |
There was a problem hiding this comment.
Suggested change
| ## Adding New Functions/Converters | |
| Before raising a PR with a new function or converter, raise a PR to verify its acceptance. While acceptance is strongly specific to a specific use case, consider these guidelines for early assessment. | |
| ## Adding New Editors/Converters | |
| Before raising a PR with a new Editor or Converter, raise an issue to describe the proposed function. While acceptance strongly depends on factors specific to each proposal, consider these guidelines for early assessment. |
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
@djaglowski I'm very interested in your opinion here, as new functions are similar to new stanza operators. |
djaglowski
reviewed
May 29, 2024
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
TylerHelmuth
added
the
Skip Changelog
TylerHelmuth
approved these changes
Jun 12, 2024
evan-bradley
approved these changes
Jun 13, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As discussed here we should agree on some guidelines when it comes to creating proposals for new functions and converters
cc @TylerHelmuth
Link to tracking Issue: -
Testing: -
Documentation: -