[chore][exporter/elasticsearch] Add benchmark for logs consumer #33035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
reviewed
May 14, 2024
lahsivjar
changed the title
carsonip
approved these changes
May 14, 2024
ycombinator
approved these changes
May 14, 2024
carsonip
approved these changes
May 16, 2024
andrzej-stencel
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM 👍 Results from my laptop:
$ cd exporter/elasticsearchexporter/integrationtest
$ go test -v -bench=. -run=nothing
goos: linux
goarch: amd64
pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/integrationtest
cpu: 13th Gen Intel(R) Core(TM) i7-13700H
BenchmarkLogsExporter
BenchmarkLogsExporter/small_batch
BenchmarkLogsExporter/small_batch-20 8426 279010 ns/op 97037 B/op 791 allocs/op
BenchmarkLogsExporter/medium_batch
BenchmarkLogsExporter/medium_batch-20 340 2964026 ns/op 977727 B/op 7817 allocs/op
BenchmarkLogsExporter/large_batch
BenchmarkLogsExporter/large_batch-20 56 32440576 ns/op 9704922 B/op 77806 allocs/op
BenchmarkLogsExporter/xlarge_batch
BenchmarkLogsExporter/xlarge_batch-20 4 295870231 ns/op 95430408 B/op 771524 allocs/op
PASS
ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/integrationtest 11.359s
andrzej-stencel
pushed a commit
that referenced
this pull request
May 22, 2024
…3087) **Description:** Similar to #33035 the PR adds benchmarks for `ConsumeTraces`. The PR also updates the mock es receiver to handle `traces` properly in order to have better readability of the tests/benchmarks and avoid confusion with the special handling -- this is done by using separate index configuration for traces and logs to distinguish the items in the bulk indexer payload. The PR also adds an extra metric to the benchmarks (`Consume{Traces, Logs}`) for reporting events consumed per second. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** [32504](#32504) **Testing:** `cd exporter/elasticsearchexporter/integrationtest && go test -bench=BenchmarkExporter -run=^$ ./...` **Documentation:** N/A
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a benchmark for elasticsearch exporter's
LogsConsumer.Link to tracking Issue: 32504
Testing:
cd exporter/elasticsearchexporter/integrationtest && go test -bench=BenchmarkLogsExporter -run=^$ ./...Documentation: N/A