Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsemf] Add AppSignals metadata flag into user-agent in EMF exporter #32998

Merged

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented May 11, 2024

Description:

Cherry-picking from downstream: amazon-contributing#105

This PR adds AppSignals metadata flag in user-agent in EMF exporter, so CWLogs backend can indicate EMF logs request type for the corresponding actions

Link to tracking Issue:

Testing:
Unit Testing

Documentation:

@jj22ee jj22ee marked this pull request as ready for review May 16, 2024 17:31
bryan-aguilar
bryan-aguilar previously approved these changes May 22, 2024
@bryan-aguilar bryan-aguilar added the ready to merge Code review completed; ready to merge by maintainers label May 22, 2024
Copy link
Contributor

@bryan-aguilar bryan-aguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for dismissing my review after approval. The idea of making the options more generalized came to me a bit later but I think it could be a good way to avoid a tight scope.

internal/aws/cwlogs/cwlog_client.go Outdated Show resolved Hide resolved
internal/aws/cwlogs/cwlog_client.go Outdated Show resolved Hide resolved
@bryan-aguilar bryan-aguilar removed the ready to merge Code review completed; ready to merge by maintainers label May 22, 2024
@bryan-aguilar bryan-aguilar dismissed their stale review May 22, 2024 23:13

Let's take another look at the option scope.

internal/aws/cwlogs/cwlog_client.go Outdated Show resolved Hide resolved
internal/aws/cwlogs/cwlog_client.go Outdated Show resolved Hide resolved
internal/aws/cwlogs/cwlog_client.go Outdated Show resolved Hide resolved
@jj22ee
Copy link
Contributor Author

jj22ee commented May 29, 2024

In latest commit:

  • Replaced WithEnabledAppSignals with WithUserAgentExtras(ex1, ex2, ....)
    • strings provided to WithUserAgentExtras will be added to user agent of the cliennt
  • Logic to add "AppSignals" string is now done outside of cwlog_client, now inside emf_exporter

Before this change, cwlog_client will control what strings can get added to the user agent based on flags set by the "WithOption" inputs. Now, there is a "WithOption" input to explicitly add strings to user agent. Pinging @bryan-aguilar

@jj22ee
Copy link
Contributor Author

jj22ee commented Jun 1, 2024

Thanks! Can this PR be marked as ready for merge?

@jj22ee
Copy link
Contributor Author

jj22ee commented Jun 4, 2024

pinging @jpkrohling @bogdandrutu @bryan-aguilar for merge

@jj22ee
Copy link
Contributor Author

jj22ee commented Jun 7, 2024

We will need a different approver/maintainer to help approve/merge this PR, afaik @bryan-aguilar may not be available to do this as of now.

Can you take a look @jpkrohling @bogdandrutu

@jj22ee
Copy link
Contributor Author

jj22ee commented Jun 11, 2024

@fatsheep9146 Could you help take a look for approving our PR for merge? We have sufficient reviews from AWS side, and @bryan-aguilar is currently not be available to help continue his review afaik.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 26, 2024
@dmitryax dmitryax merged commit 041812a into open-telemetry:main Jun 26, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants