-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awsemf] Add AppSignals metadata flag into user-agent in EMF exporter #32998
[exporter/awsemf] Add AppSignals metadata flag into user-agent in EMF exporter #32998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for dismissing my review after approval. The idea of making the options more generalized came to me a bit later but I think it could be a good way to avoid a tight scope.
Let's take another look at the option scope.
In latest commit:
Before this change, cwlog_client will control what strings can get added to the user agent based on flags set by the "WithOption" inputs. Now, there is a "WithOption" input to explicitly add strings to user agent. Pinging @bryan-aguilar |
Thanks! Can this PR be marked as ready for merge? |
pinging @jpkrohling @bogdandrutu @bryan-aguilar for merge |
We will need a different approver/maintainer to help approve/merge this PR, afaik @bryan-aguilar may not be available to do this as of now. Can you take a look @jpkrohling @bogdandrutu |
@fatsheep9146 Could you help take a look for approving our PR for merge? We have sufficient reviews from AWS side, and @bryan-aguilar is currently not be available to help continue his review afaik. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
Cherry-picking from downstream: amazon-contributing#105
This PR adds AppSignals metadata flag in user-agent in EMF exporter, so CWLogs backend can indicate EMF logs request type for the corresponding actions
Link to tracking Issue:
Testing:
Unit Testing
Documentation: