-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection] Add support for Bare Metal Solution GCP platform #32985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this still needs tests
Sure, what specific tests would you like me to implement? |
You should add a case similar to other platforms, e.g.: opentelemetry-collector-contrib/processor/resourcedetectionprocessor/internal/gcp/gcp_test.go Lines 144 to 163 in a133a8e
|
Done. PTAL ? |
Looks like you still need to add a changelog entry. See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#changelog for how to do that. |
I've added a changelog entry. PTAL ? |
289843b
into
open-telemetry:main
Description: Add support for Bare Metal Solution platform to the GCP resourcedetection processor
FYI I had to place the check for gcp.BareMetalSolution before !metadata.OnGCE() because the latter fails on Bare Metal Solution due to the absence of a metadata server.
Link to tracking Issue:
Testing: unit tests updated
Documentation: