Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/opampsupervisor]: Allow configuring agent description #32819

Merged
merged 9 commits into from
May 15, 2024
Merged

[cmd/opampsupervisor]: Allow configuring agent description #32819

merged 9 commits into from
May 15, 2024

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented May 2, 2024 •
edited
Loading

Description:

  • Add options to the configuration that allows configuring the agent description

Link to tracking Issue: Closes #32824

Testing: e2e test, unit tests for validation

Documentation:

  • Updated spec with configuration parameters

BinaryFissionGames
BinaryFissionGames commented May 2, 2024
View reviewed changes
cmd/opampsupervisor/e2e_test.go

require.Equal(t, expectedDescription, ad.AgentDescription)

time.Sleep(250 * time.Millisecond)
Copy link
Contributor Author

@BinaryFissionGames BinaryFissionGames May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this sleep, the supervisor gets stuck shutting down.

This is the same race I had to address in #32618 in order to get tests to run properly for that PR. This can be removed once the fix from that PR is merged.

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review May 2, 2024 15:26
@BinaryFissionGames BinaryFissionGames requested a review from a team May 2, 2024 15:26
@BinaryFissionGames
Copy link
Contributor Author

@tigrannajaryan Are you able to give this a review?

tigrannajaryan
tigrannajaryan approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cmd/opampsupervisor/specification/README.md Outdated Show resolved Hide resolved
@BinaryFissionGames @tigrannajaryan
Update cmd/opampsupervisor/specification/README.md
cf57dfa 
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
@andrzej-stencel andrzej-stencel merged commit 4d5fbfb into open-telemetry:main May 15, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 15, 2024
This was referenced May 16, 2024
Merged
Closed
evan-bradley pushed a commit that referenced this pull request May 16, 2024
@BinaryFissionGames
[cmd/opampsupervisor]: Add storage dir to e2e test config to fix test…
c3b68d6 
… failure (#33095)

**Description:** <Describe what has changed.>
fixes test failure observed in #33093 (due to merge of #32819 and
#32618)

**Link to tracking Issue:** Closes #33093

**Testing:** run supervisor e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedr jedr jedr approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
cmd/opampsupervisor
Projects
None yet
Milestone
v0.101.0
Development

Successfully merging this pull request may close these issues.

[cmd/opampsupervisor]: Allow configuring the agent description
5 participants
@BinaryFissionGames @jedr @tigrannajaryan @andrzej-stencel @Aneurysm9