[chore] Move newNodeSharedInformer to a common/shared pkg #32591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
requested review from
dmitryax,
fatsheep9146 and
TylerHelmuth
as code owners
github-actions
bot
added
internal/k8sconfig
processor/k8sattributes
ChrsMark
force-pushed
the
refactor_k8s_node_informer
branch
from
ae4df3a
to
77bd740
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
refactor_k8s_node_informer
branch
from
77bd740
to
073f37c
Compare
ChrsMark
requested review from
Aneurysm9,
dashpole,
mx-psi and
songy23
as code owners
github-actions
bot
added
connector/datadog
exporter/datadog
|
I'm not sure if the failure is related or it is some "flakiness" 🤔 . PASS
ok github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer 15.464s |
TylerHelmuth
approved these changes
Apr 22, 2024
|
@open-telemetry/collector-contrib-approvers any change I could get more eyes on this please? |
mx-psi
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements some basic refactoring required for #32295.
Doing this in a standalone PR was requested at #32295 (comment).
The change moves a library method called
newNodeSharedInformerfrom thek8sattributesprocessor package to a generic one since it can be re-used by multiple various components.Note: I'm not sure if a changelog is required for this change, so I left it out for now.
Link to tracking Issue:
Testing:
Documentation: